[storage/log/variable] reduce # of blob read_at calls from 3 to 2 in read and read_buffered
#1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes blob reading performance by reducing the number of read_at syscalls from 3 to 2 when reading journal entries. Instead of making separate calls to read the item data and checksum, the code now reads both in a single operation and extracts the components from the combined buffer.
- Combines item and checksum reads into a single
read_atcall with a larger buffer - Extracts item data and checksum from the combined buffer using slicing
- Removes unnecessary
.as_ref()calls where direct references are available
b888130 to
663a599
Compare
read_at calls from 3 to 2 in readread_at calls from 3 to 2 in read
b29ef74 to
663a599
Compare
read_at calls from 3 to 2 in readread_at calls from 3 to 2 in read and read_buffered
663a599 to
7e432ea
Compare
7e432ea to
1a415d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
- Coverage 91.20% 91.20% -0.01%
==========================================
Files 248 248
Lines 62084 62083 -1
==========================================
- Hits 56623 56622 -1
Misses 5461 5461
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of most archive::immutable benchmarks by ~30%. This code uses journal.get instead of get_exact. Since prunable archive currently uses get_exact, there is no performance impact on that.