Skip to content

[storage/adb] Introduce adb::immutable #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2025
Merged

[storage/adb] Introduce adb::immutable #1317

merged 5 commits into from
Jul 24, 2025

Conversation

roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo commented Jul 24, 2025 •
edited
Loading

Addresses #1294

@roberto-bayardo roberto-bayardo force-pushed the adb-append branch 10 times, most recently from 1aceec4 to 6aa0172 Compare July 24, 2025 17:44
patrick-ogrady
patrick-ogrady reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks very on track!

examples/sync/src/lib.rs

/// Operation type alias.
pub type Operation = commonware_storage::adb::operation::Operation<Key, Value>;
pub type Operation = commonware_storage::adb::operation::Fixed<Key, Value>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

storage/src/adb/append.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's keep iterating on this name. immutable isn't quite right because we can prune, however, if we opt to just prune memory (recent keys in the index configurably), then it may be ok.

@roberto-bayardo roberto-bayardo force-pushed the adb-append branch 2 times, most recently from 094afe5 to 69f0579 Compare July 24, 2025 18:28
@roberto-bayardo roberto-bayardo marked this pull request as ready for review July 24, 2025 19:58
patrick-ogrady
patrick-ogrady reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close now!

For name, let's just go with adb::immutable for now (it isn't perfect but I like it better than append for this...at least for now).

@roberto-bayardo roberto-bayardo force-pushed the adb-append branch 4 times, most recently from 2a6fd91 to d3aad7f Compare July 24, 2025 22:27
@patrick-ogrady patrick-ogrady changed the title [storage/adb] add adb where keys can only be set & never changed [storage/adb] Introduce adb::immutable Jul 24, 2025
patrick-ogrady
patrick-ogrady approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@patrick-ogrady patrick-ogrady merged commit 11e4fd0 into main Jul 24, 2025
33 checks passed
@patrick-ogrady patrick-ogrady deleted the adb-append branch July 24, 2025 22:55
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 94.78528% with 34 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (a3a186f) to head (ed87849).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
storage/src/adb/immutable.rs 96.84% 15 Missing ⚠️
storage/src/adb/operation.rs 83.33% 13 Missing ⚠️
utils/src/array/u32.rs 86.95% 6 Missing ⚠️ 
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   91.20%   91.29%   +0.09%     
==========================================
  Files         248      250       +2     
  Lines       62083    63308    +1225     
==========================================
+ Hits        56622    57800    +1178     
- Misses       5461     5508      +47
Files with missing lines Coverage Δ
storage/src/adb/any/mod.rs 98.90% <100.00%> (ø)
storage/src/adb/any/sync/client.rs 93.24% <100.00%> (ø)
storage/src/adb/any/sync/resolver.rs 83.67% <ø> (ø)
storage/src/adb/current.rs 96.87% <100.00%> (ø)
storage/src/journal/variable.rs 93.03% <100.00%> (+0.12%) ⬆️
utils/src/array/u32.rs 86.95% <86.95%> (ø)
storage/src/adb/operation.rs 88.06% <83.33%> (-8.37%) ⬇️
storage/src/adb/immutable.rs 96.84% <96.84%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a186f...ed87849. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roberto-bayardo @patrick-ogrady