-
Notifications
You must be signed in to change notification settings - Fork 111
[cryptography] Introduce LtHash
#1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an LtHash
implementation, which is an additive homomorphic hash function built on top of Blake3. The implementation allows for efficient incremental updates to hash sets by supporting addition, subtraction, and combination operations while maintaining commutativity and associativity properties.
- Implements a new
LtHash
struct with homomorphic hash capabilities - Provides comprehensive benchmarking suite for performance analysis
- Includes extensive test coverage for all mathematical properties
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
cryptography/src/lthash/mod.rs | Core implementation of the LtHash homomorphic hash function with full API |
cryptography/src/lib.rs | Adds lthash module to the public API |
cryptography/Cargo.toml | Adds benchmark configuration for lthash |
cryptography/src/lthash/benches/*.rs | Complete benchmarking suite testing various operations |
Comments suppressed due to low confidence (2)
cryptography/src/lthash/mod.rs:52
- The method
finalize()
is called in the example but the actual method is namedchecksum()
. This will cause the example to fail compilation.
//! assert_eq!(lthash.finalize(), lthash2.finalize());
cryptography/src/lthash/mod.rs:59
- The method
finalize()
is called in the example but the actual method is namedchecksum()
. This will cause the example to fail compilation.
//! assert_eq!(lthash2.finalize(), lthash3.finalize());
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
+ Coverage 91.20% 91.23% +0.02%
==========================================
Files 247 248 +1
Lines 61686 61930 +244
==========================================
+ Hits 56258 56499 +241
- Misses 5428 5431 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Resolves: #1304
Results