[adb] lowercase log starts and error messages #1295
Conversation
…ed nodes correctly
storage/src/adb/operation.rs
Outdated
| for _ in 0..V::SIZE { | ||
| if buf.get_u8() != 0 { | ||
| return Err(CodecError::Invalid("Operation", "Delete value non-zero")); | ||
| return Err(CodecError::Invalid("operation", "delete value non-zero")); |
There was a problem hiding this comment.
We've used a full path for "Invalid" before...tbh we may be able to pull this automatically with some rust built-in:
monorepo/consensus/src/aggregation/types.rs
Line 286 in 1274609
There was a problem hiding this comment.
Updated to "storage::adb::Operation"
| Adb(crate::adb::Error), | ||
| /// Maximum retries exceeded | ||
| #[error("Maximum retries exceeded")] | ||
| MaxRetriesExceeded, |
There was a problem hiding this comment.
Unrelated to the rest of the PR, but this wasn't used, so I removed it
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 91.16% 91.16% -0.01%
==========================================
Files 246 246
Lines 61236 61242 +6
==========================================
+ Hits 55828 55831 +3
- Misses 5408 5411 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
For consistency, changes logs and error messages to start with lowercase