[storage] Introduce ordinal + Ensure destroy() Deletes Entire Partition
#1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ordinalordinal + Ensure destroy() Deletes Entire Partition
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ordinal storage engine for sparse, fixed‐size records and updates existing storage modules so that calling destroy() removes the entire partition. It also adds benchmark support for the new engine.
- Add
ordinalmodule with anOrdinaltype supporting put/get/has/prune/sync/close/destroy - Ensure
destroy()removes the entire partition inordinal,metadata, and bothjournalimplementations - Wire up benchmarks for
ordinalinCargo.tomland add bench code understorage/src/ordinal/benches
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/src/ordinal/storage.rs | New Ordinal implementation with full lifecycle and partition destroy |
| storage/src/ordinal/mod.rs | Module docs, type exports, config and error definitions |
| storage/src/ordinal/benches/utils.rs | Benchmark helpers for ordinal |
| storage/src/ordinal/benches/restart.rs | Restart benchmark |
| storage/src/ordinal/benches/put.rs | Put benchmark |
| storage/src/ordinal/benches/get.rs | Get benchmark |
| storage/src/ordinal/benches/bench.rs | Criterion runner setup |
| storage/src/metadata/storage.rs | Added partition-wide remove in metadata's destroy |
| storage/src/journal/variable.rs | Added partition-wide remove in variable-journal's destroy |
| storage/src/journal/fixed.rs | Added partition-wide remove in fixed-journal's destroy |
| storage/src/lib.rs | Exposed new ordinal module |
| storage/Cargo.toml | Registered ordinal benchmarks |
Comments suppressed due to low confidence (3)
storage/src/ordinal/mod.rs:80
- The example calls the async
putmethod without.await. Update tostore.put(0, value1).await.unwrap();(and similarly for the otherputcalls) so the snippet compiles correctly.
//! store.put(0, value1).unwrap();
storage/src/journal/variable.rs:682
- The code references
RErrorbut there’s nouse commonware_runtime::Error as RError;import in this file, causing a compilation error. Please add the import alongside othercommonware_runtimeimports.
Err(RError::PartitionMissing(_)) => {
storage/src/journal/fixed.rs:520
- This block uses
RError::PartitionMissingbut the aliasRErrorisn’t imported here. Adduse commonware_runtime::Error as RError;with the other imports.
match self.context.remove(&self.cfg.partition, None).await {
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 91.28% 91.40% +0.11%
==========================================
Files 216 218 +2
Lines 58364 59510 +1146
==========================================
+ Hits 53278 54393 +1115
- Misses 5086 5117 +31
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1135
Changes
sync