Skip to content

Conversation

patrick-ogrady
Copy link
Contributor

Spans were added while benchmarking examples::flood but now are causing issues with tests. Removing until we actually need them (at which point we can review if this was even the right approach).

@patrick-ogrady patrick-ogrady changed the title [p2] Remove spans [p2p] Remove spans Jun 29, 2025
@patrick-ogrady patrick-ogrady merged commit fcdf0ab into main Jun 29, 2025
28 checks passed
@patrick-ogrady patrick-ogrady deleted the remove-spans branch June 29, 2025 23:38
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (af8473f) to head (6f0d873).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
p2p/src/authenticated/discovery/actors/listener.rs 55.55% 4 Missing ⚠️
p2p/src/authenticated/lookup/actors/listener.rs 55.55% 4 Missing ⚠️
p2p/src/authenticated/discovery/actors/dialer.rs 66.66% 3 Missing ⚠️
p2p/src/authenticated/lookup/actors/dialer.rs 66.66% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
- Coverage   91.11%   91.09%   -0.03%     
==========================================
  Files         216      216              
  Lines       57831    57779      -52     
==========================================
- Hits        52694    52634      -60     
- Misses       5137     5145       +8     
Files with missing lines Coverage Δ
p2p/src/authenticated/discovery/actors/dialer.rs 95.40% <66.66%> (-0.39%) ⬇️
p2p/src/authenticated/lookup/actors/dialer.rs 95.40% <66.66%> (-0.39%) ⬇️
p2p/src/authenticated/discovery/actors/listener.rs 86.36% <55.55%> (-2.32%) ⬇️
p2p/src/authenticated/lookup/actors/listener.rs 86.36% <55.55%> (-2.32%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8473f...6f0d873. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant