[storage/metadata] Address Feedback #1179
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| while i < next_data.len() { | ||
| // Skip equal bytes | ||
| while i < next_data.len() && i < target_data.len() && next_data[i] == target_data[i] { | ||
| // Fast-forward over identical blocks |
There was a problem hiding this comment.
This should dramatically speed up sync performance over sparse diffs.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses feedback by refactoring the metadata storage system. Key changes include:
- Replacing the tuple-based blob storage with a dedicated Wrapper struct.
- Updating the load and sync functions to work with the new Wrapper abstraction.
- Adjusting documentation comments and test assertion error formatting for consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| storage/src/metadata/storage.rs | Refactored blob storage to use a Wrapper struct and updated related load and sync logic. |
| storage/src/metadata/mod.rs | Updated documentation comments to reference [Metadata] and modified test assertions formatting. |
Comments suppressed due to low confidence (1)
storage/src/metadata/mod.rs:546
- The test assertion's format string "{buffer}" will not interpolate the
buffervariable as intended. Consider updating it to use "{}", buffer to ensure that the error message displays the actual buffer content.
assert!(buffer.contains("skipped_total 0"), "{buffer}");
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
+ Coverage 91.08% 91.21% +0.13%
==========================================
Files 216 216
Lines 57795 57964 +169
==========================================
+ Hits 52640 52874 +234
+ Misses 5155 5090 -65
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Related: #1175