Skip to content

feat: Extend Hasher trait with empty() #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

feat: Extend Hasher trait with empty() #1166

merged 2 commits into from
Jun 30, 2025

Conversation

varun-doshi
Copy link
Contributor

Closes #1024

@roberto-bayardo
Copy link
Collaborator

Please update this function to use the new method:

monorepo/storage/src/mmr/mem.rs

Line 103 in fb59cd8

fn dirty_digest() -> H::Digest {

@roberto-bayardo roberto-bayardo self-assigned this Jun 29, 2025
@roberto-bayardo roberto-bayardo self-requested a review June 29, 2025 17:28
@roberto-bayardo roberto-bayardo removed their assignment Jun 29, 2025
@varun-doshi
Copy link
Contributor Author

Please update this function to use the new method:

Done

roberto-bayardo
roberto-bayardo approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@roberto-bayardo roberto-bayardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@patrick-ogrady patrick-ogrady merged commit d29e63c into commonwarexyz:main Jun 30, 2025
12 of 16 checks passed
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (fb59cd8) to head (22c4aaa).
Report is 7 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         215      215           
  Lines       57409    57432   +23     
=======================================
+ Hits        52256    52279   +23     
  Misses       5153     5153
Files with missing lines Coverage Δ
cryptography/src/lib.rs 100.00% <ø> (ø)
cryptography/src/sha256/mod.rs 96.49% <100.00%> (+0.88%) ⬆️
storage/src/mmr/mem.rs 92.37% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb59cd8...22c4aaa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberto-bayardo roberto-bayardo roberto-bayardo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cryptography] Extend Hasher trait with empty()

3 participants

@varun-doshi @roberto-bayardo @patrick-ogrady