[storage/adb/any] add benchmark for adb::any startup #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a Criterion benchmark that measures the startup time of an adb::any database by generating a large random DB and timing reopen operations.
- Introduces a new bench harness (
bench.rs) for adb/any. - Implements random-data generation and initialization timing in
anydb_init.rs. - Adjusts snapshot read buffer size in
any.rs. - Registers the new benchmark in
storage/Cargo.toml.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| storage/src/adb/benches/bench.rs | Adds criterion_main! entry for anydb_init::benches. |
| storage/src/adb/benches/anydb_init.rs | Implements generation of a large random DB and async benchmark for init timing. |
| storage/src/adb/any.rs | Increases SNAPSHOT_READ_BUFFER_SIZE from 64KiB to 128KiB. |
| storage/Cargo.toml | Registers a new bench target named adb. |
c0b47da to
ea7ba7d
Compare
ea7ba7d to
9dab587
Compare
9dab587 to
0c9bf95
Compare
1f5971a to
41e40ab
Compare
41e40ab to
21cf3ec
Compare
patrick-ogrady
approved these changes
Jun 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
- Coverage 91.01% 90.98% -0.04%
==========================================
Files 191 214 +23
Lines 55231 57430 +2199
==========================================
+ Hits 50270 52253 +1983
- Misses 4961 5177 +216 see 67 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark creates a large-ish random DB, closes it, then times how long it takes to re-open.