[stream] Add fuzz tests for handshake #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made some small tweaks 👍 |
patrick-ogrady
approved these changes
Jun 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 90.98% 91.02% +0.04%
==========================================
Files 215 215
Lines 57313 57416 +103
==========================================
+ Hits 52145 52262 +117
+ Misses 5168 5154 -14
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic fuzz tests for
stream.handshakefuzzes the low-level primitive of the handshake protocol, which is why it requires some private handshake types.Now I just made them public and also removed
cfg(test)for x25519'sPublicKey::from_bytes. I think you may have better ideas on how to implement that more correctly. If you do not want to make any changes to your type system, then we can remove thehandshaketest.