[cryptography] Add fuzz targets #1124
Conversation
|
Please add a line here for cryptography: monorepo/.github/workflows/fast.yml Lines 106 to 107 in 579520d |
cryptography/fuzz/Cargo.toml
Outdated
| commonware-cryptography = { workspace = true } | ||
| arbitrary = { workspace = true, features = ["derive"] } | ||
| blst = { version = "0.3.13", features = ["no-threads"] } | ||
| ed25519-zebra = "4.0.3" |
There was a problem hiding this comment.
Was there a certain rationale for using ed25519-zebra instead of ed25519-consensus (what we use internally)?
There was a problem hiding this comment.
It is just for diff testing. The production code still uses ed25519-consensus.
There was a problem hiding this comment.
By that logic, I suppose we should spend some time looking for alternatives to blst and p256 in the future?
There was a problem hiding this comment.
The main reason I wanted to use zebra was because it has the same validation criteria as ed25519-consensus and follows the same Zcash serialization spec. I think it would be fruitful to test against other alternatives but like we discussed it is hard to find a good p256 alternative, and I think the only production grade library for BLS is blst.
Fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
+ Coverage 90.97% 90.99% +0.01%
==========================================
Files 214 214
Lines 57426 57342 -84
==========================================
- Hits 52245 52178 -67
+ Misses 5181 5164 -17 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR adds fuzz targets for the cryptography crate.