Skip to content

[storage/mmr] Use Strategy #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

[storage/mmr] Use Strategy #1103

merged 2 commits into from
Jun 13, 2025

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jun 13, 2025 •
edited
Loading

Related: #1069

Copilot

This comment was marked as outdated.

Sign in to view

@patrick-ogrady patrick-ogrady requested a review from Copilot June 13, 2025 15:15
Copilot
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the enum from SyncType to Strategy to clarify its role in determining the update behaviors in the MMR benchmark.

  • Renamed SyncType to Strategy.
  • Updated variable names and match statements to reflect the new enum name.

@patrick-ogrady patrick-ogrady merged commit 61e1388 into main Jun 13, 2025
15 checks passed
@patrick-ogrady patrick-ogrady deleted the tweak-benchmark-name branch June 13, 2025 15:16
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (7f34495) to head (6237e3e).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         191      191           
  Lines       55122    55122           
=======================================
  Hits        50151    50151           
  Misses       4971     4971

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f34495...6237e3e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@roberto-bayardo roberto-bayardo roberto-bayardo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patrick-ogrady @roberto-bayardo