[nit] remove unneeded ticks #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
previously approved these changes
Jun 11, 2025
|
Unfortunately I don't know a good way for the linter to catch this... |
broadcast/src/buffered/config.rs
Outdated
| use commonware_cryptography::PublicKey; | ||
|
|
||
| /// Configuration for the [`Engine`](super::Engine). | ||
| /// Configuration for the [Engine](super::Engine). |
There was a problem hiding this comment.
I wonder if it is a good idea to use this opportunity to just use things directly?
i.e. switch to [super::Engine] syntax?
| //! The `Voter` caches all data required to participate in consensus to avoid any disk reads on | ||
| //! on the critical path. To enable recovery, the `Voter` writes valid messages it receives from | ||
| //! consensus and messages it generates to a write-ahead log (WAL) implemented by [Journal](https://docs.rs/commonware-storage/latest/commonware_storage/journal/index.html). | ||
| //! consensus and messages it generates to a write-ahead log (WAL) implemented by [commonware_storage::journal::variable::Journal]. |
patrick-ogrady
approved these changes
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
+ Coverage 91.01% 91.03% +0.02%
==========================================
Files 191 191
Lines 55217 55284 +67
==========================================
+ Hits 50253 50329 +76
+ Misses 4964 4955 -9
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ` don't do anything. We only need them sometimes in
//! Doc commentswhen it thinks that the<T>inside, e.g.Vec<T>is an HTML tag.