Skip to content

[p2p] Factor out authenticated Mailbox implementations #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 18, 2025
Merged

[p2p] Factor out authenticated Mailbox implementations #1072

merged 17 commits into from
Jun 18, 2025

Conversation

danlaine
Copy link
Collaborator

@danlaine danlaine commented Jun 6, 2025 •
edited
Loading

We arguably don't even need the Mailbox type, which is just a wrapper around a sender. I think the diff is smaller (or at least simpler) as I did it in this PR as compared to just using the raw mpsc::Sender.

This PR also removes unneeded type bounds on spawner::Message.

@danlaine danlaine self-assigned this Jun 6, 2025
@danlaine danlaine marked this pull request as ready for review June 6, 2025 15:11
@danlaine danlaine marked this pull request as draft June 10, 2025 21:58
@danlaine danlaine marked this pull request as ready for review June 18, 2025 21:53
@patrick-ogrady patrick-ogrady merged commit 15dee37 into main Jun 18, 2025
16 checks passed
@patrick-ogrady patrick-ogrady deleted the danlaine/remove-mailbox branch June 18, 2025 22:14
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (541f9d6) to head (0b5fc52).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
p2p/src/authenticated/mailbox.rs 81.25% 3 Missing ⚠️
...c/authenticated/discovery/actors/router/ingress.rs 87.50% 1 Missing ⚠️
.../src/authenticated/lookup/actors/router/ingress.rs 87.50% 1 Missing ⚠️ 
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   90.97%   90.98%           
=======================================
  Files         214      215    +1     
  Lines       57345    57313   -32     
=======================================
- Hits        52171    52146   -25     
+ Misses       5174     5167    -7
Files with missing lines Coverage Δ
p2p/src/authenticated/discovery/actors/dialer.rs 95.78% <100.00%> (ø)
p2p/src/authenticated/discovery/actors/listener.rs 88.67% <100.00%> (ø)
...p/src/authenticated/discovery/actors/peer/actor.rs 85.71% <100.00%> (+5.14%) ⬆️
...src/authenticated/discovery/actors/peer/ingress.rs 100.00% <100.00%> (ø)
...src/authenticated/discovery/actors/router/actor.rs 86.36% <100.00%> (ø)
...rc/authenticated/discovery/actors/spawner/actor.rs 92.38% <100.00%> (+0.30%) ⬆️
.../authenticated/discovery/actors/spawner/ingress.rs 100.00% <100.00%> (ø)
...rc/authenticated/discovery/actors/tracker/actor.rs 97.96% <100.00%> (+<0.01%) ⬆️
.../authenticated/discovery/actors/tracker/ingress.rs 86.30% <100.00%> (-2.21%) ⬇️
p2p/src/authenticated/discovery/network.rs 80.29% <ø> (ø)
... and 13 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541f9d6...0b5fc52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Assignees

@danlaine danlaine

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danlaine @patrick-ogrady