[storage/hasher] remove unnecessary generic hasher parameter from root testers #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies root tester helpers by removing the generic hasher parameter and hard-coding Sha256, then updates call sites accordingly.
- Removed generic
<H: CHasher>from batched root test helpers and instantiated a Sha256 hasher inside each helper. - Updated all test invocations in
mem.rsandjournaled.rsto match the new helper signatures.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| storage/src/mmr/tests/mod.rs | Dropped generic hasher type, now creates a Sha256 + Standard hasher internally |
| storage/src/mmr/mem.rs | Updated call to build_batched_and_check_test_roots (removed hasher arg) |
| storage/src/mmr/journaled.rs | Updated call to build_batched_and_check_test_roots_journaled |
patrick-ogrady
approved these changes
Jun 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
- Coverage 91.03% 91.03% -0.01%
==========================================
Files 191 191
Lines 54359 54357 -2
==========================================
- Hits 49485 49482 -3
- Misses 4874 4875 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root stability tests require Sha256, so no point in allowing the hasher to be parameterized.