[runtime] add io_uring metrics; make test less flaky #1023
Conversation
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_force_poll_enabled() { |
There was a problem hiding this comment.
I think we should keep both tests and either:
- add a sleep between submitting recv/write (the retained test isn't guaranteed to test the timeout for the same reason the removed one is flaking)
- add a metric for outstanding work in iouring and poll on that being non-zero before submitting the next op (failing if it exceeds the timeout, which should never happen).
fcf20b2 to
fa0d08a
Compare
runtime/src/tokio/runtime.rs
Outdated
| storage_directory: self.cfg.storage_directory.clone(), | ||
| ring_config: Default::default(), | ||
| }), | ||
| }, runtime_registry), |
There was a problem hiding this comment.
wonder if we should prefix with iouring-*?
There was a problem hiding this comment.
prefixed with "io_uring_storage". If you want something else lmk.
runtime/src/tokio/runtime.rs
Outdated
| if #[cfg(feature = "iouring-network")] { | ||
| let network = MeteredNetwork::new( | ||
| IoUringNetwork::start(crate::iouring::Config::default()).unwrap(), | ||
| IoUringNetwork::start(crate::iouring::Config::default(),runtime_registry).unwrap(), |
There was a problem hiding this comment.
we should also prefix this with iouring_network
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 90.95% 90.97% +0.02%
==========================================
Files 191 192 +1
Lines 53777 54094 +317
==========================================
+ Hits 48912 49212 +300
- Misses 4865 4882 +17
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Adds metrics to the io_uring