[codec] Add More Varint Coverage
#1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varint CoverageVarint Edge Cases
patrick-ogrady
commented
May 29, 2025
patrick-ogrady
commented
May 29, 2025
patrick-ogrady
commented
May 29, 2025
patrick-ogrady
commented
May 29, 2025
Varint Edge CasesVarint Coverage
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage to the varint codec implementation by exhaustively verifying encoding and decoding for u16/i16 values and testing boundary cases for values with specific bit patterns.
- Adds exhaustive tests for every possible u16 and i16 value.
- Implements tests for exact bit boundaries and single bit boundary cases across multiple integer types.
BrendanChou
approved these changes
May 29, 2025
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 90.96% 90.95% -0.01%
==========================================
Files 191 191
Lines 53587 53671 +84
==========================================
+ Hits 48743 48818 +75
- Misses 4844 4853 +9
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.