-
Notifications
You must be signed in to change notification settings - Fork 111
[CI] Fix IoError
Lint Issue on main
#1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses Clippy lint errors by replacing direct calls to IoError::new(ErrorKind::Other, …)
with the more idiomatic IoError::other(…)
.
- Replaces multiple
IoError::new(ErrorKind::Other, …)
invocations withIoError::other(…)
. - Consolidates error construction into single-line calls.
Comments suppressed due to low confidence (1)
runtime/src/storage/iouring.rs:237
- Consider adding a unit test to exercise the
truncate
error path (e.g., whenset_len
fails) to ensure the newIoError::other
mapping behaves as expected.
Error::BlobTruncateFailed(self.partition.clone(), hex(&self.name), IoError::other(e))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses Clippy lint io_other_error
by replacing IoError::new(ErrorKind::Other, …)
calls with the more concise IoError::other(…)
.
- Update
truncate
error construction to useIoError::other
. - Update various Blob sync error cases to use
IoError::other
.
main
IoError
Lint Error on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CI lint errors in the iouring storage module by updating error instantiation to use the newly introduced IoError::other variant instead of IoError::new with ErrorKind::Other.
- Removed the unused ErrorKind import.
- Updated error instantiation in Blob methods to conform with Clippy's recommendations.
IoError
Lint Error on main
IoError
Lint Issue on main
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 190 190
Lines 52632 52632
=======================================
Hits 47789 47789
Misses 4843 4843 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
It seems a new version of Rust borked CI.