[deployer] Perform Deletion Concurrently + Activate Automatic Retry #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the EC2 resource deletion process by executing deletions concurrently and enhances the AWS client configuration with an adaptive retry mechanism.
- Introduces concurrent deletion jobs for EC2 resources using try_join_all
- Configures an adaptive retry strategy with defined max attempts and backoff parameters in the AWS client
- Minor update to inline comments for punctuation consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deployer/src/ec2/destroy.rs | Adds asynchronous job creation to perform concurrent resource deletion |
| deployer/src/ec2/aws.rs | Updates the AWS client configuration to use an adaptive retry strategy with backoff limits |
Comments suppressed due to low confidence (1)
deployer/src/ec2/destroy.rs:48
- [nitpick] Consider renaming the variable 'job' to something more descriptive like 'teardown_task' to clarify its purpose in scheduling EC2 resource deletion.
let job = async move {
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 90.82% 90.79% -0.03%
==========================================
Files 190 190
Lines 52617 52630 +13
==========================================
Hits 47787 47787
- Misses 4830 4843 +13
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the latest
altodeploy, I ran into a number of flaky failures. After making this change, it was able to complete successfully: