[crypto] Give Committable and Digestible associated types
#945
Conversation
cryptography/src/lib.rs
Outdated
| /// An object that shares a (commitment) [Digest] with other, related values. | ||
| pub trait Committable<D: Digest>: Clone + Sized + Send + Sync + 'static { | ||
| /// An object that can produce a commitment of itself. | ||
| pub trait Committable: Clone + Sized + Send + Sync + 'static { |
There was a problem hiding this comment.
We could add Committable: Digestible to make:
pub struct Engine<E: Clock + Spawner + Metrics, P: Array, M: Committable + Digestible + Codec> {into
pub struct Engine<E: Clock + Spawner + Metrics, P: Array, M: Committable + Codec> {but I think it'd be OK to leave as is, too.
There was a problem hiding this comment.
As discussed offline, I think it makes sense to keep these separate 👍
index.html
Outdated
There was a problem hiding this comment.
I think this snuck in here @danlaine
| pub struct Engine< | ||
| E: Clock + Spawner + Metrics, | ||
| P: Array, | ||
| Dc: Digest, |
There was a problem hiding this comment.
Not sure why I didn't think to myself "there must be a better way" when adding this 😓 .
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #945 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 190 190
Lines 52630 52632 +2
=======================================
+ Hits 47787 47789 +2
Misses 4843 4843
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.