Skip to content

Port SitemapExtractor from CC-MRJob to CC-PySpark #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Port SitemapExtractor from CC-MRJob to CC-PySpark #54

wants to merge 10 commits into from

Conversation

@damian0815
Copy link

@damian0815 damian0815 commented Oct 17, 2025 •
edited
Loading

  • Basic functionality unit tests
  • warcio implementation
    • Validate output is identical to MRJob output with "test" robotstxt in MRJob repo
    • Validate on recent full-scale crawl output
  • fastwarc implementation
  • unit test to validate text encoding edge cases and validity (currently all test cases are completely valid utf8)
  • check output works with crawl-tools/server/seed/sitemaps/sitemaps_robotstxt.py

@damian0815 damian0815 marked this pull request as draft October 17, 2025 15:27
@damian0815 damian0815 marked this pull request as ready for review October 20, 2025 14:24
fix logging
d17683f 
Signed-off-by: Damian Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-nagel sebastian-nagel Awaiting requested review from sebastian-nagel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@damian0815