[types] Remove module augmentation #566
Merged
+127
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the module augmentation from `index.d.ts`, instead putting the relevant properties directly into `color.d.ts`.
|
@jgerigmeyer Requested review because I'd like to know whether you think there's any better way to do this—imo it seems like module augmentations should just be avoided with the weirdness they seem to have caused. |
jgerigmeyer
approved these changes
Jun 26, 2024
MysteryBlokHed
added a commit
that referenced
this pull request
Jun 27, 2024
This is essentially the same change as #566, but for the main branch instead of a patch for v0.5.
MysteryBlokHed
added a commit
that referenced
this pull request
Jun 27, 2024
This is essentially the same change as #566, but for the main branch instead of a patch for v0.5.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561
Note: This change is for v0.5 of color.js, hence the target branch being
v0.5.x. It should also be implemented before the release of v0.6.0, but that can be done at a later date.Removes the module augmentation from
index.d.ts, instead putting the relevant properties directly intocolor.d.ts. This should the errors being reported on newer versions of TypeScript.