Demonstrate JND with colours that are different #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It does seem silly to ask the reader if two identical colors look the same...because of course they do. It seems like a good idea to alter the colors to be slightly different, but visually hard to distinguish. |
facelessuser
approved these changes
Jul 1, 2024
svgeesus
approved these changes
Jul 4, 2024
Probably a "copy, paste, got distracted, thought I was done" operation. Thanks for fixing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Color differences" page in the docs illustrates the Just Noticeable Difference (JND) with a pair of identical colours. This patch changes one of them slightly.
I don't know what the original intention was, although I assume that there being no difference isn't deliberate. So I went with a change that meant that ΔΕ > 2.3 for two of the three algorithms demonstrated. My thinking was that this gives the reader a chance to judge these algorithms (and/or the 2.3 threshold) against their own ability to see a difference.