Add write_model functions for python scripts #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds functions to write models using python, be it binary of textual Tests have been added too Both have been renamed for their new functionality
ahojnnes
reviewed
Dec 9, 2019
scripts/python/read_write_model.py
Outdated
| return qvec | ||
|
|
||
|
|
||
| parser = argparse.ArgumentParser(description='Read and write COLMAP binary and text models') |
There was a problem hiding this comment.
No need to run this code when importing the model. Otherwise these arguments will be injected in other scripts importing this module. Can you move it to the main function?
|
Looks great, left one minor comment. Thanks! |
This commit also unifies the notation between the binary and text writers Finally, it now longers takes the key of the dictionnary for id to let the user use they key dict they want
|
Hi thanks for you comment ! I updated my code with several improvements in addition to your suggestion :
Clément |
|
Looks great, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds functions to write models using python, be it binary of textual
Tests have been added too
Both have been renamed for their new functionality