tests/verify/check-connection fix issues in opensuse #22695
+39
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensuse on opensuse the default config that is expected is actually in /usr/etc/ssh/ssh_config we can not use sed as the file does not exist
images on openSUSE in most os-release files comments are not present however on opensuse tumbleweed the os-release does contain comments, this just drops every comment allowing the envsubst to work as expected. The branding test assumes logo.png is present on every image, it is not present on opensuse, to resolve this issue instead we look up default.png. Over the past few months there has been an overhaul in openSUSE's wallpapers pacakge. This updates the install-data-hook to create a valid symlink to default.png instead of default-1920x1200.jpg which no longer exists.
jelly
requested changes
Dec 17, 2025
| self.write_file("/etc/ssh/sshd_config", "PermitEmptyPasswords yes") | ||
| m.execute(self.restart_sshd) | ||
| else: | ||
| self.sed_file('$ a\\\nPermitEmptyPasswords yes', '/etc/ssh/sshd_config',self.restart_sshd) |
Member
There was a problem hiding this comment.
This commit also changes the pixel changes test/reference can you drop that please
| * The array itself gets allocated and must be freed after use. */ | ||
| static const char ** | ||
| strsplit (char *string, char delimiter) | ||
| strsplit (char *string, char delimiter, unsigned *len_out) |
Member
There was a problem hiding this comment.
Can you elaborate a bit more on the goal of this patch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the issues with
tests/verify/check-connectionand should make this set of tests run without issues. There are some changes tosrc/common/cockpitconf.cto handle /etc not being apart ofXDG_CONFIG_DIRS.