Add optimistic recipient application flow #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs links... light mode / dark mode not yet addressed
todo: light mode? update link to docs
tracks the furthest step touched with form state. Need to pass a method that returns boolean if step should be green or not based on form validity and if it's a page that has been visited. Methods are set up, but wasn't able to pass to template using dynamic props.
TODO: pull actual ENS
ENS lookup requires mainnet provider. Adds a .env var for a mainnet endpoint (infura works), should readdress for prod
Add recipient transaction on form submission
Landing buttons only full width on mobile
IPFS upload refactor
What does it mean? Could you provide a more detailed list of changes? |
wraps image in div with declared width, and aspect-ratio to determine height. bug: image set to 100% width/height and `object-fit: cover` within that div, but not filling as expected.
nests selector
allows reusable copy/link functionality when rendering an IPFS hash
PR for join cleanup
Recipient flow cleanup
Fixes TS type error blocking all current `develop` branched
Update RecipientSubmissionWidget.vue, ts linting fix
Fixes address wrapping on mobile [Fixes #41]
Fix maxRecipients calculation
|
Sorry for the noise here - closing this out until we get this a bit more polished. I'll create a summary of changes in the PR description when I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR on an updated recipient application flow.
Purpose of this is to kick off discussion w/ CLR.fund team on what aspects they'd like merged & what they don't. Happy to close this out & make more granular PRs as needed.