Skip to content

Fix reallocation and contract verification errors #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2024
Merged

Fix reallocation and contract verification errors #759

merged 6 commits into from
Jun 17, 2024

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Jun 4, 2024 •
edited
Loading

Fixes in this PR:

  1. Fix the contract verification errors caused by missing constructor arguments for Tally and MessageProcessor.
  2. Add verification of user registry and recipient registry added to the ClrFund contract
  3. Add sepolia etherscan url for the round export task
  4. Fix reallocation error due to missing key caused by incorrect subgraph id contruction

@yuetloo yuetloo self-assigned this Jun 4, 2024
@yuetloo yuetloo requested a review from auryn-macmillan June 4, 2024 04:26
@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for clrfund-staging ready!

Name Link
🔨 Latest commit 65dc41b
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-staging/deploys/665f13ba0511720008217ab9
😎 Deploy Preview https://deploy-preview-759--clrfund-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for clrfund-testnet ready!

Name Link
🔨 Latest commit 65dc41b
🔍 Latest deploy log https://app.netlify.com/sites/clrfund-testnet/deploys/665f13bab890ce0008e53c20
😎 Deploy Preview https://deploy-preview-759--clrfund-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuetloo yuetloo changed the title Fix contract verification errors and add missing sepolia url Fix reallocation and contract verification errors Jun 4, 2024
auryn-macmillan
auryn-macmillan approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuetloo yuetloo merged commit 3171017 into develop Jun 17, 2024
@yuetloo yuetloo deleted the fix/verify-export-issue branch June 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees

@yuetloo yuetloo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuetloo @auryn-macmillan