Add incremental deployment and manual nonce management options #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case as token does not exist on optimism-sepolia
✅ Deploy Preview for clrfund-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
auryn-macmillan
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incremental contract deployment feature is useful especially in the production environment to allow restart from a failed deployment.
The manual nonce management is useful for some node (e.g. optimism Sepolia public node) where the node sometimes returns older nonce. This option will allow the deployment script to manually increment the nonce instead of querying the node for the next nonce value. This allows deployment to run successfully.
This PR also added the option to verify contracts after deployment.
For example, the following command to deploy a new ClrFund instance with the options to verify contract after deployment and manually set the nonce in each deployment transaction and only deploy contracts that haven't deployed in previous run.
After successful deployment, the contract addresses will be recorded in the file
contracts/deployed-contracts.jsonThe new deployment script will also need configuration in the
contracts/deploy-config.jsonfile