add jinja2 template parsing #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6b1467 to
439a886
Compare
439a886 to
eb72f97
Compare
|
Great feature! This is so cool! |
phobologic
approved these changes
Feb 19, 2019
19e8c30 to
a245962
Compare
|
@phobologic I dug into the variable resolution timing and fixed it. Should work as expected now. |
|
Thanks @troyready ! |
|
Nice job @troyready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to make it completely opt-in by requiring templates to be explicitly named
*.j2, so this won't affect anyone that doesn't explicitly chose to use it.