Skip to content

feat: support new thrift binary generic call api, server streaming generic call and unknown service or method handler #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 1, 2025
Merged

feat: support new thrift binary generic call api, server streaming generic call and unknown service or method handler #1837

merged 5 commits into from
Sep 1, 2025

Conversation

jayantxie
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners August 20, 2025 11:07
@jayantxie jayantxie force-pushed the feat/generic_server_streaming branch from f16c4f7 to ebadd2d Compare August 20, 2025 11:59
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.34777% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.03%. Comparing base (ca63109) to head (45bb29a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generic/generic_service.go 68.04% 22 Missing and 9 partials ⚠️
pkg/generic/streaming.go 46.00% 26 Missing and 1 partial ⚠️
client/genericclient/client.go 71.76% 20 Missing and 4 partials ⚠️
pkg/generic/generic.go 94.59% 8 Missing and 2 partials ⚠️
pkg/remote/trans/ttstream/frame.go 59.09% 6 Missing and 3 partials ⚠️
pkg/generic/httppbthrift_codec.go 63.15% 6 Missing and 1 partial ⚠️
pkg/generic/thrift/raw.go 72.72% 5 Missing and 1 partial ⚠️
server/service.go 96.57% 5 Missing and 1 partial ⚠️
pkg/generic/httpthrift_codec.go 73.68% 5 Missing ⚠️
server/genericserver/unknownservice.go 66.66% 3 Missing and 2 partials ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   60.26%   61.03%   +0.77%     
==========================================
  Files         381      385       +4     
  Lines       34447    34663     +216     
==========================================
+ Hits        20759    21157     +398     
+ Misses      12427    12223     -204     
- Partials     1261     1283      +22
Flag Coverage Δ
integration 50.08% <68.31%> (+1.48%) ⬆️
unit 51.12% <48.37%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the feat/generic_server_streaming branch 2 times, most recently from ac08d32 to 6d54fe2 Compare August 21, 2025 15:07
DMwangnima
DMwangnima reviewed Aug 22, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Aug 22, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Aug 22, 2025
View reviewed changes
@jayantxie jayantxie force-pushed the feat/generic_server_streaming branch 3 times, most recently from 075bf07 to 84760a6 Compare August 25, 2025 08:00
@jayantxie jayantxie force-pushed the feat/generic_server_streaming branch from 84760a6 to 103aaae Compare August 25, 2025 08:42
DMwangnima
DMwangnima reviewed Aug 28, 2025
View reviewed changes
YangruiEmma
YangruiEmma previously approved these changes Aug 29, 2025
View reviewed changes
AsterDY
AsterDY reviewed Aug 29, 2025
View reviewed changes
AsterDY
AsterDY reviewed Aug 29, 2025
View reviewed changes
@jayantxie jayantxie merged commit 024fedb into cloudwego:main Sep 1, 2025
25 checks passed
@jayantxie jayantxie changed the title feat: generic server streaming feat: support new thrift binary generic call api, server streaming generic call and unknown service or method handler Sep 23, 2025
@BrewTestBot BrewTestBot mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsterDY AsterDY AsterDY left review comments

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jayantxie @YangruiEmma @AsterDY @DMwangnima