optimize(gRPC): return more detailed error when received invalid http2 frame #1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1717 +/- ##
===========================================
+ Coverage 57.40% 57.42% +0.01%
===========================================
Files 408 408
Lines 37696 37697 +1
===========================================
+ Hits 21640 21648 +8
+ Misses 14739 14728 -11
- Partials 1317 1321 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiaost
approved these changes
Feb 28, 2025
HeyJavaBean
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
optimize(gRPC): 收到无效的 http2 帧时返回更详细的错误
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
When a non-HTTP2 Frame is received, the original
http2: frame too largeerror is somewhat misleading, print out the first 8 bytes to better troubleshoot the problemzh(optional):
当收到非 HTTP2 Frame 时，原本的
http2: frame too large错误会带来一定误导，为了更好地排查问题打印出前 8 个字节(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: