Extend services bindings to support VPC Services. #10628
Conversation
e.g. `"services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]`
🦋 Changeset detectedLatest commit: 524d2ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
| @@ -891,29 +891,46 @@ export interface EnvironmentNonInheritable { | |||
| * @nonInheritable | |||
| */ | |||
| services: | |||
There was a problem hiding this comment.
This is a pretty unusual way to add a new binding. Usually there'd be a new top level key vpcs which had these VPC services under it. Is there a particular reason this needs to be under services? I think it's probably going to cause a fair amount of user confusion, and will make the implementation more complex
| service_id: binding.service_id, | ||
| }; | ||
| } else { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
| if ("service_id" in serviceBinding && serviceBinding.service_id) { | ||
| metadataBindings.push({ | ||
| name: serviceBinding.binding, | ||
| type: "connectivity_service_binding", |
There was a problem hiding this comment.
This is a different binding type to service, and so should really be a different config property
There was a problem hiding this comment.
Also, it's a little odd to include a _binding suffix in the binding type—I don't think most others do it like that
Implements WVPC-42.
Extend services bindings to support VPC Services.
e.g.
"services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]I am pretty confident with the
deployandtypes, but less so withwrangler devand its various modes - I will need to dig in more but wanted to get this initially reviewed. Also becauseservicesis now a union (either aserviceor aservice_id) there is some added complexity here that probably needs improving.Docs PR to follow