Skip to content

default containers.max_instances to 1 #10533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

default containers.max_instances to 1 #10533

merged 1 commit into from
Sep 3, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Sep 2, 2025 •
edited by lrapoport-cf
Loading

Fixes CC-5970

previously this defaulted to 0, which meant that users would run wrangler deploy with a container, then not have any container instances available. setting the default to a 'broken' state is very confusing, so lets just default to 1.

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: containers

@emily-shen emily-shen requested review from a team as code owners September 2, 2025 17:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: 9956668

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/no-instances-warning might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10533
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 2, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10533

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10533

miniflare

npm i https://pkg.pr.new/miniflare@10533

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10533

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10533

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10533

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10533

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10533

wrangler

npm i https://pkg.pr.new/wrangler@10533

commit: 9956668

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 3, 2025
@emily-shen emily-shen merged commit c22acc6 into main Sep 3, 2025
41 of 48 checks passed
@emily-shen emily-shen deleted the emily/no-instances-warning branch September 3, 2025 10:02
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 3, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung