Skip to content

native node:fs and node:os are no more experimental #10498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

native node:fs and node:os are no more experimental #10498

merged 3 commits into from
Sep 1, 2025
+35 −89

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 29, 2025 •
edited
Loading

The experimental flag for node:fs and node:os was removed in https://github.com/cloudflare/workerd/releases/tag/v1.20250827.0

Note: this PR is expected to fail until wrangler/miniflare have been updated to use workerd >= 20250827 (rebased on main which now uses 1.20250829.0)

Flag definition:

  enableNodeJsFsModule @105 :Bool
    $compatEnableFlag("enable_nodejs_fs_module")
    $compatDisableFlag("disable_nodejs_fs_module")
    $impliedByAfterDate(name = "nodeJsCompat", date = "2025-09-15");
  # Enables the Node.js fs module. It is required to use this flag with
  # nodejs_compat (or nodejs_compat_v2).

  enableNodeJsOsModule @106 :Bool
    $compatEnableFlag("enable_nodejs_os_module")
    $compatDisableFlag("disable_nodejs_os_module")
    $impliedByAfterDate(name = "nodeJsCompat", date = "2025-09-15");
  # Enables the Node.js os module. It is required to use this flag with
  # nodejs_compat (or nodejs_compat_v2).

/cc @anonrig @danlapid @jasnell

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it will be documented by the runtime team (docs are not published yet)
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@vicb vicb requested review from a team as code owners August 29, 2025 11:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2d29845

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/unenv-preset Patch
@cloudflare/vite-plugin Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 29, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 29, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10498

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10498

miniflare

npm i https://pkg.pr.new/miniflare@10498

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10498

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10498

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10498

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10498

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10498

wrangler

npm i https://pkg.pr.new/wrangler@10498

commit: 2d29845

dario-piotrowicz
dario-piotrowicz approved these changes Aug 29, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 29, 2025
vicb
vicb commented Aug 29, 2025
View reviewed changes
anonrig
anonrig reviewed Aug 29, 2025
View reviewed changes
@vicb vicb force-pushed the vicb/fs-os-not-exp branch from 9d0b54f to 2d29845 Compare September 1, 2025 07:59
@vicb
Copy link
Contributor Author

vicb commented Sep 1, 2025

Rebase on HEAD (where workerd is 1.20250829.0 which should fix the tests)

@vicb vicb merged commit 4851955 into main Sep 1, 2025
41 of 45 checks passed
@vicb vicb deleted the vicb/fs-os-not-exp branch September 1, 2025 09:08
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 1, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @anonrig @dario-piotrowicz