🦋 Changeset detected

Latest commit: ecbb398

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey Can you please add a patch changeset?

npm i https://pkg.pr.new/create-cloudflare@10065

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10065

npm i https://pkg.pr.new/miniflare@10065

npm i https://pkg.pr.new/@cloudflare/pages-shared@10065

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10065

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10065

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10065

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10065

npm i https://pkg.pr.new/wrangler@10065

commit: ecbb398

@edmundhung Anything I still need to do to get this one merged & released?

@edmundhung Anything I still need to do to get this one merged & released?

There were some errors on some of the CI job that I wasn't sure whether they are flakes or legit error. Just trigger it to run again and will merge it when it's green. Sorry for the wait.

@edmundhung Seems like macOS is failing for some reason, but Linux is passing, so I guess it's fine to merge?

Rest of CI is all passing

@edmundhung It seems that Windows tests keep failing for some reason, but seems unrelated to my code changes

It seems that Windows tests keep failing for some reason, but seems unrelated to my code changes

That's the same error I see previously. So it seems to me not a flake anymore. I agree this doesn't looks related to your change, but let me give it another look.

There is no need to rebase your branch for now.

It isn't clear why this code would timeout after updating the package version 😅

afterEach(() => {
  if (fs.existsSync(tmpDir)) {
    process.chdir(originalCwd);
    process.env.PWD = originalCwd;
    try {
      fs.rmSync(tmpDir, { recursive: true, force: true });
    } catch {
      // ...
    }
  }
});

Nothing in the changelogs look suspicious as well

• https://github.com/mjackson/remix-the-web/releases/tag/node-fetch-server%400.7.0
• https://github.com/remix-run/remix/releases/tag/node-fetch-server%400.8.0

@edmundhung Even more strange is that it's only happening on Windows, so I would have no idea at all what's going on tbh

@MichaelDeBoey Would you have time putting up a PR updating it to v0.7.0 first? That might help identifying whether this is an issue only on v0.8.0.

@edmundhung It seems like the tests are still failing, even with v0.7, so I guess it has nothing to do with the update of the dependency and it's just a flaky test?

The browser rendering tests are inherently flakey independent of this PR. I'll just re-run and hopefully land it.

@edmundhung @petebacondarwin Any news on this one?
Seems like it keeps being stuck on the same thing, but has nothing to do with the changes I did

Would be awesome if we could merge & release this PR 🙏

I got the CI all green last night and then a conflict happen right before I am about to merge it 🙃 Just rebased it and hopefully getting it merged tonight..

Congratulations @MichaelDeBoey, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmelv10rf1436907kz24mh0nbb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@edmundhung Thanks for taking the time to keep trying! 🙏

Nah, it's all good! Sorry it took so long to get such a simple PR merged. Thanks a ton for the contribution 🙌🏼