Skip to content

ckem: move crypto/elliptic to crypto/ecdh #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2025
Merged

ckem: move crypto/elliptic to crypto/ecdh #529

merged 6 commits into from
Jan 22, 2025

Conversation

MingLLuo
Copy link
Contributor

@MingLLuo MingLLuo commented Jan 18, 2025 •
edited
Loading

TODO move over to crypto/ecdh once we can assume Go 1.20.

I found that there is an unfinished TODO in ckem.go, and the go version we use now is higher than 1.20.

Due to the limited code using crypto/ecdh in the entire repository, I can only go by my own experience with the transition, so some of the implementations may not be so satisfying.

This also help fix some problem of

TODO: replace deprecated elliptic.Marshal, elliptic.GenerateKey,
elliptic.Unmarshal, params.ScalarBaseMult before re-enabling SA1019.
in circl/.golangci.yaml

@armfazh armfazh self-requested a review January 18, 2025 23:11
@armfazh armfazh self-assigned this Jan 18, 2025
@armfazh armfazh added the enhancement Improvement over something already in the project label Jan 18, 2025
bwesterb
bwesterb reviewed Jan 20, 2025
View reviewed changes
bwesterb
bwesterb reviewed Jan 20, 2025
View reviewed changes
armfazh
armfazh requested changes Jan 22, 2025
View reviewed changes
@armfazh armfazh mentioned this pull request Jan 22, 2025
Merged
@MingLLuo MingLLuo requested a review from armfazh January 22, 2025 05:34
@armfazh armfazh merged commit 4987803 into cloudflare:main Jan 22, 2025
10 checks passed
@armfazh
Copy link
Contributor

armfazh commented Jan 22, 2025

Thanks @MingLLuo

project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner-as-gitea-act-runner-fork that referenced this pull request Jul 3, 2025