Skip to content

Expire the search cache #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Expire the search cache #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850d62c
Expire the search cache
Isty001 Jan 11, 2021
089990f
Expire the search cache
Isty001 Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/common/clib-cache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ int clib_cache_delete_json(char *author, char *name, char *version) {
return unlink(json_cache);
}

int clib_cache_has_search(void) { return 0 == fs_exists(search_cache); }
int clib_cache_has_search(void) {
return 0 == fs_exists(search_cache) && !is_expired(search_cache);
}

char *clib_cache_read_search(void) {
if (!clib_cache_has_search()) {
Expand Down
22 changes: 20 additions & 2 deletions test/cache/cache-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <limits.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

#define assert_exists(f) assert_equal(0, fs_exists(f));

Expand Down Expand Up @@ -36,11 +37,15 @@ int main() {
char *version = "1.2.0";
char pkg_dir[BUFSIZ];

it("should initialize succesfully") { assert_equal(0, clib_cache_init(1)); }
int expiraton = 1;

it("should initialize succesfully") {
assert_equal(0, clib_cache_init(expiraton));
}

sprintf(pkg_dir, "%s/author_pkg_1.2.0", clib_cache_dir());

it("should manage package the cache") {
it("should manage the package cache") {
assert_equal(
0, clib_cache_save_package(author, name, version, "../../deps/copy"));
assert_equal(1, clib_cache_has_package(author, name, version));
Expand Down Expand Up @@ -85,6 +90,19 @@ int main() {
assert_equal(0, clib_cache_has_search());
assert_null(clib_cache_read_search());
}

it("should expire the search cache") {
clib_cache_delete_search();

assert_equal(13, clib_cache_save_search("<html></html>"));
assert_equal(1, clib_cache_has_search());

sleep(expiraton + 1);

assert_equal(0, clib_cache_has_search());
}

clib_cache_delete_search();
}

return assert_failures();
Expand Down