Skip to content

Conversation

ptxmac
Copy link
Contributor

@ptxmac ptxmac commented Jan 20, 2021

This allows the user to specify the contents of the commit message when merging.

Especially useful when squashing commits, where github by default will contact the message of all commits into the body.

partially addresses #1023

@mislav
Copy link
Contributor

mislav commented Jan 20, 2021

Hi, thank you for the contribution! Some description on what this is trying to solve would be nice instead of an empty pull request body. Is this meant to address #1023?

@ptxmac
Copy link
Contributor Author

ptxmac commented Jan 20, 2021

Hi, thank you for the contribution! Some description on what this is trying to solve would be nice instead of an empty pull request body. Is this meant to address #1023?

Yup, sorry about that, just updated the description

@vilmibm vilmibm self-assigned this Jan 20, 2021
@mgabeler-lee-6rs
Copy link
Contributor

Will this allow changing the entire commit message, including the first line, or just the "followup" pieces. AKA in terms of the GH web UI, does this encompass both fields from the merge form, or just the second one?

@vilmibm
Copy link
Contributor

vilmibm commented Jan 21, 2021

@mgabeler-lee-6rs not the entire message, just the "under" portion

@vilmibm vilmibm merged commit 4d28c79 into cli:trunk Jan 21, 2021
@dpromanko
Copy link
Contributor

@vilmibm should there be a prompt in interactive mode to specify a body if choosing merge?

Additionally it seems a little odd that the -b flag only really does anything when also specifying the -m flag. With any other merge option this flag is thrown out entirely. From a git perspective it makes sense, but from the cli user perspective it silently does nothing. Maybe some type of warning output about improper usage and that it will be ignored?

@ptxmac ptxmac deleted the ptx/pr-merge-body branch February 1, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants