Consistently use success icon #2799
Conversation
For operations such as closing an issue or merging a PR, we would display the success icon (a checkmark) in red and magenta colors, respectively, to reflect the latest state of the record operated on (red: closed; magenta: merged). This was always confusing to me, seeing it both in code and in the UI, because I'm instinctively thinking that it's a bug and have to remind myself that it's by design.
|
Hey thanks for this proposal! While I'm really glad to clean up our use of the check unicode character, I do feel pretty strongly about our color use as it is now. The color association on GitHub of "closed" = red/deleted, "merged" = purple is really strong, and I would argue stronger than "green" = success, especially in these contexts. For example, when something is "successfully closed", I believe the check icon represents the "success" concept, while the red represents the "closed" concept. To see green in this context, I would be confused since green is so strongly associated with "opening" something. Curious if anyone else has thoughts! |
|
i like the current color scheme and find it helpful fwiw |
|
Thank you for the feedback! I will revert the color behavior to always use the end state of the record (even if it's red/magenta), but I will try to express it more idiomatically in code so that the reader is clear on the fact that this is a desired behavior and not a typo. 👍 |
|
I've updated the branch to add a new |
Sure! Updated. |
For operations such as closing an issue or merging a PR, we would display the success icon (a checkmark) in red and magenta colors, respectively, to reflect the latest state of the record operated on (red: closed; magenta: merged).
This was always confusing to me, seeing it both in code and in the UI, because I'm instinctively thinking that it's a bug and have to remind myself that it's by design.
Here I'm proposing that we always use the green checkmark icon to indicate a successful operation, regardless of the end state of the record. As a bonus fix, we now use the
✓character consistently, as opposed to✔in some places.