Skip to content

Generate correct URL when branch option is passed in #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

Generate correct URL when branch option is passed in #2404

merged 2 commits into from
Nov 13, 2020

Conversation

alissonbrunosa
Copy link
Contributor

@alissonbrunosa alissonbrunosa commented Nov 13, 2020 •
edited
Loading

Summary

closes #2401

Details

The URL generator wasn't using the branch option when it was passed in

mislav
mislav approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you!

@mislav mislav merged commit 6a0d38d into cli:trunk Nov 13, 2020
@mislav mislav mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to view specific branch using gh repo view

2 participants

@alissonbrunosa @mislav