-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Refactor pr/issue creation code #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Sooo much easier to parse and reason about. I left a a handful of comments/questions, nothing truly blocking though.
aa9573a
to
f5277e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing the hard work 🙇
In working on #2313 it struck me that the pr create command has become unmaintainable:
for a human to keep it in their head
This PR has these goals:
The only "functional" change I ended up with is not computing defaults in cases where we are definitely not going to use them (ie when both title and body have already been provided via CLI args).