Emoji parsing in Readme content #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilmibm
approved these changes
Sep 21, 2020
|
Note that this approach will erroneously replace To ensure we only replace |
|
this is great ! |
|
@mislav , @vilmibm I noticed this renderer bug today too. Since this PR is merged already is it worth creating an new issue for fixing the renderer? I understand this is probably low priority 🙂 from from strongswan/README.md: |
|
@luckman212 I think it would be best to open a new issue, for ease of tracking, and just reference this one in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1771
Installed emoji, an emoji library in go which has additional emoji aliases from gemoji (used by github) and extra features. It fixes the bug of emoji parsing in displaying readme content.