Skip to content

Add vercel as oauth provider #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolfand merged 1 commit into from
Dec 15, 2025
Merged

Add vercel as oauth provider #303

swolfand merged 1 commit into from
Dec 15, 2025

Conversation

@swolfand
Copy link
Contributor

@swolfand swolfand commented Dec 15, 2025 •
edited by coderabbitai bot
Loading

This pull request adds support for the Vercel OAuth provider to the OAuthProvider enum in the authentication models. The changes ensure that Vercel is now recognized as a valid OAuth provider throughout the codebase.

New OAuth provider support:

  • Added .vercel case to the OAuthProvider enum.
  • Included .vercel in the allCases array so it is recognized as a supported provider.
  • Implemented the .vercel case in the provider details mapping, returning the correct provider information for Vercel.

Summary by CodeRabbit

  • New Features
    • Added Vercel as an available OAuth provider for user authentication.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025 •
edited
Loading

Walkthrough

A new OAuth provider, Vercel, is added to the OAuthProvider enum with its corresponding strategy mapping and metadata for OAuth authentication support.

Changes

Cohort / File(s) Summary
OAuth Provider Addition
Sources/Clerk/Models/OAuthProvider.swift		 Added new vercel OAuth provider case to enum, included in allCases array, and configured with provider data mapping (provider: "vercel", strategy: "oauth_vercel", name: "Vercel")

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file with minimal, straightforward changes
  • Follows existing enum pattern consistently
  • Direct data mapping addition with no complex logic

Poem

🐰 A Vercel case hops into the fold,
With OAuth strategy, brave and bold,
In enum rows, a new path shines,
Where provider data aligns—
Swift integration, clean and neat! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add vercel as oauth provider' directly and accurately summarizes the main change: adding Vercel as a new OAuth provider to the OAuthProvider enum.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sam/mobile-365-ios-add-vercel-as-oauth-type
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dbcc7dd and 8da4027.

📒 Files selected for processing (1)
  • Sources/Clerk/Models/OAuthProvider.swift (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Build on all platforms (iOS)
  • GitHub Check: Build on all platforms (tvOS)
  • GitHub Check: Build on all platforms (visionOS)
  • GitHub Check: Build on all platforms (macOS)
  • GitHub Check: Build on all platforms (macCatalyst)
  • GitHub Check: Build on all platforms (watchOS)
  • GitHub Check: Run tests on macOS
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
Sources/Clerk/Models/OAuthProvider.swift (3)

39-39: LGTM! Enum case added correctly.

The .vercel case follows the established naming convention and is properly positioned before the .custom catch-all case.

74-75: LGTM! Added to allCases array as required.

The .vercel provider is correctly included in the allCases array, following the comment guidance to add all new cases (excluding .custom).

321-326: LGTM! Provider data mapping follows the established pattern.

The provider data for Vercel correctly implements the standard pattern:

  • Provider identifier: "vercel"
  • Strategy: "oauth_vercel"
  • Display name: "Vercel"

All three critical changes for adding a new OAuth provider have been implemented correctly.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swolfand swolfand merged commit bac471e into main Dec 15, 2025
9 checks passed
@swolfand swolfand deleted the sam/mobile-365-ios-add-vercel-as-oauth-type branch December 15, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikepitre mikepitre mikepitre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolfand @mikepitre