Skip to content

Conversation

@Noelle-M
Copy link
Contributor

@Noelle-M Noelle-M commented May 16, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no

plugin:
admin_tools:
- name: privacy
class: shield-halved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce devrait être juste shield

arguments:
- '@Claroline\AppBundle\API\SerializerProvider'
- '@Claroline\AppBundle\Persistence\ObjectManager'
- '@Claroline\CoreBundle\Library\Configuration\PlatformConfigurationHandler'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déjà déclaré par le core, à supprimer (tu ne déclares que tes propres services).


const PrivacyTool = (props) =>
<ToolPage
title={trans('privacy')}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

par défaut, le component ToolPage affiche le nom de l'outil, pas besoin de spécifier le title.

@Elorfin Elorfin changed the title Privacy adds privacy plugin May 17, 2023
@Elorfin Elorfin merged commit 87535da into main May 17, 2023
@Elorfin Elorfin deleted the new-2 branch May 17, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants