Skip to content

Extension of JsonCodec to have parity features with generic.extra #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aparo wants to merge 9 commits into from
Closed

Extension of JsonCodec to have parity features with generic.extra #91

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f9f3c1
Added default value management and sealed trait to derivation macro
aparo Aug 12, 2019
600f84a
All test passed
aparo Aug 12, 2019
b7e2fb8
Added .metals and .bloop to .gitignore
aparo Aug 12, 2019
af80a4e
Updated circe to 0.12.0-RC2
aparo Aug 12, 2019
a117913
Removed comments
aparo Aug 12, 2019
40f365c
Merge branch 'master' of github.com:aparo/circe-derivation
aparo Aug 12, 2019
c660501
Applied sbt scalafmt
aparo Aug 12, 2019
9f37826
Removed unused comment
aparo Aug 12, 2019
4d55ecc
Unification names with circe.generic.auto: nameTransformation => tran…
aparo Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed comments
  • Loading branch information
@aparo
aparo committed Aug 12, 2019
commit a117913b2160b7ef365b705ae18ccf999f2c569a
4 changes: 0 additions & 4 deletions modules/derivation/shared/src/main/scala/io/circe/derivation/DerivationMacros.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,10 +358,8 @@ class DerivationMacros(val c: blackbox.Context) extends ScalaVersionCompat {
): c.Expr[Decoder[T]] = {
val tpe = weakTypeOf[T]

// Valid only in macro!!
val globalUseDefaults: Boolean = extractUseDefaults(useDefaults.tree)
Copy link
Member

@travisbrown travisbrown Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the name here. In what sense is it global?

Copy link
Contributor Author

@aparo aparo Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename in useDefaults



def transformName(name: String): Tree =
nameTransformation.fold[Tree](q"$name")(f => q"$f($name)")

Expand Down Expand Up @@ -709,8 +707,6 @@ class DerivationMacros(val c: blackbox.Context) extends ScalaVersionCompat {
case s: String if s.contains("withTypeDiscriminator") =>
Discriminator.TypeDiscriminator
case _ =>
// print(showRaw(tree))
// print(tree)
Discriminator.default
}
}
Expand Down