Skip to content

Conversation

@IAlibay
Copy link
Contributor

@IAlibay IAlibay commented Apr 22, 2025

Description

Fixes #772

Fixes for NP2.0 found by ruff.

Status

  • Ready to go

Changelog message

ruff fixes for numpy 2.0

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (8045f21) to head (7b7ac08).
Report is 6 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay
Copy link
Contributor Author

IAlibay commented Apr 22, 2025

cc @ijpulidos and @mikemhenry, looks lik ethis is all we needed?

@mikemhenry
Copy link
Contributor

that should do it, can you update the env yaml to pull in numpy 2.0 just as a quick check?

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to test numpy 2

@IAlibay
Copy link
Contributor Author

IAlibay commented Apr 22, 2025

@mikemhenry the 8.2 runners already pick up numpy 2.0 :)

@mikemhenry mikemhenry merged commit 5cdd135 into choderalab:main Apr 22, 2025
22 checks passed
@IAlibay IAlibay deleted the numpy-2.0 branch April 22, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multistatesampler.py dying with AttributeError: np.Inf was removed in the NumPy 2.0 release. Use np.inf instead.

2 participants