Issue #18197: Fix indentation check for line-wrapped return statements #18289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18197
The default indentation check configuration doesn't correctly assess indentation for line-wrapped expressions in return statements. As a result, it misses indentation violations in these expressions. In contrast, the same violations are properly identified when the expression is stored in an intermediate variable.
this code shows the issue-
I modified the BlockParentHandler class to add special handling for return statements with line-wrapped expressions. The fix:
Detects when a return statement's expression spans multiple lines
Uses
checkWrappingIndentation()to properly check continuation linesEnsures error messages show the operator name (via LineWrappingHandler.logWarningMessage() which uses currentNode.getText())