Skip to content

Prepare for cert-manager v1.15.0: cleanup imports, point to local test package #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2024
Merged

Prepare for cert-manager v1.15.0: cleanup imports, point to local test package #76

merged 4 commits into from
Jun 4, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jun 4, 2024

In preparation for cert-manager v1.15.0, we had to fix a few issues in this repo:

  • replace "github.com/cert-manager/cert-manager/pkg/webhook/handlers/testdata" with "github.com/cert-manager/cmctl/v2/test/integration/testdata"
  • prepare for pki.BuildCertManagerKeyUsages which will be removed
  • prepare for context parameter for c.Run(..)

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
@inteon
Copy link
Member Author

inteon commented Jun 4, 2024

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@inteon
run gci
9ba875c 
Signed-off-by: Tim Ramlot <[email protected]>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@cert-manager-prow cert-manager-prow bot merged commit bf55968 into cert-manager:main Jun 4, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inteon @ThatsMrTalbot