Skip to content

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jul 11, 2025

There are some new CRD fields introduced in cert-manager 1.18, which I've added to the internal conversion API structs, and regenerated the conversion functions.

```
_bin/tools/go get github.com/cert-manager/cert-manager@latest
make go-tidy
```

Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2025
// Profile allows requesting a certificate profile from the ACME server.
// Supported profiles are listed by the server's ACME directory URL.
// +optional
Profile string `json:"profile,omitempty"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR, the rule is that new fields should be added to the old APIs too so that the field value is not lost when converting between old and new versions. The concept is described here:

I don't think the rule is relevant here, since these conversions are for the cmctl convert tool which only needs to convert from old API types to v1, but I've done it anyway to satisfy the roundtrip tests which attempt to convert between all the supported versions.

@wallrj wallrj requested a review from inteon July 11, 2025 11:44
@inteon
Copy link
Member

inteon commented Jul 11, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@cert-manager-prow cert-manager-prow bot merged commit a18f2d3 into cert-manager:main Jul 11, 2025
5 checks passed
@wallrj wallrj deleted the update-dependency-cert-manager-1.18.2 branch July 11, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants