Fix gw ARP. Make ARP probe public. Add ARP event #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpq
reviewed
Oct 7, 2024
scaprile
commented
Oct 7, 2024
| // hack: 30 min before deadline, try to rebind (4.3.6) every min | ||
| tx_dhcp_request_re(ifp, (uint8_t *) broadcast, ifp->ip, 0xffffffff); | ||
| } // TODO(): Handle T1 (RENEWING) and T2 (REBINDING) (4.4.5) | ||
| if (ifp->enable_dhcp_client && expired_1000ms) { |
There was a problem hiding this comment.
We can't send DHCP probes unless DHCP is actually enabled
scaprile
commented
Oct 7, 2024
There was a problem hiding this comment.
See comments in net_builtin.c
scaprile
commented
Oct 7, 2024
scaprile
commented
Oct 9, 2024
scaprile
commented
Oct 9, 2024
scaprile
commented
Oct 9, 2024
scaprile
commented
Oct 9, 2024
cpq
reviewed
Oct 10, 2024
cpq
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpq For some reason you added this branch, and it was left behind. Rebased.